diff options
| author |   Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-07-01 10:27:53 +0200 |
|---|---|---|
| committer |   Thierry Reding <thierry.reding@gmail.com> | 2021-07-08 16:08:54 +0200 |
| commit | 25f70b8f3d15b8c188ecb49c6007b86f3e775c20 (patch) | |
| tree | 4582d764741a201ffa48f532e651280e96e2f56d /drivers/pwm | |
| parent | pwm: spear: Ensure configuring period and duty_cycle isn't wrongly skipped (diff) | |
| download | linux-dev-25f70b8f3d15b8c188ecb49c6007b86f3e775c20.tar.xz linux-dev-25f70b8f3d15b8c188ecb49c6007b86f3e775c20.zip | |
pwm: tiecap: Ensure configuring period and duty_cycle isn't wrongly skipped
As the last call to ecap_pwm_apply() might have exited early if
state->enabled was false, the values for period and duty_cycle stored in
pwm->state might not have been written to hardware and it must be
ensured that they are configured before enabling the PWM.
Fixes: 0ca7acd84766 ("pwm: tiecap: Implement .apply() callback")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm')
| -rw-r--r-- | drivers/pwm/pwm-tiecap.c | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c index dec3f1fb150c..35eb19a5a0d1 100644 --- a/drivers/pwm/pwm-tiecap.c +++ b/drivers/pwm/pwm-tiecap.c @@ -189,16 +189,13 @@ static int ecap_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, return 0; } - if (state->period != pwm->state.period || - state->duty_cycle != pwm->state.duty_cycle) { - if (state->period > NSEC_PER_SEC) - return -ERANGE; + if (state->period > NSEC_PER_SEC) + return -ERANGE; - err = ecap_pwm_config(chip, pwm, state->duty_cycle, - state->period, enabled); - if (err) - return err; - } + err = ecap_pwm_config(chip, pwm, state->duty_cycle, + state->period, enabled); + if (err) + return err; if (!enabled) return ecap_pwm_enable(chip, pwm); |