diff options
| author |   Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-06-17 11:51:42 +0200 |
|---|---|---|
| committer |   Thierry Reding <thierry.reding@gmail.com> | 2021-06-30 19:12:20 +0200 |
| commit | 3b8b571fcc49e794703eb01a97e9ed8b85e88304 (patch) | |
| tree | d198b811cfe953e5a18dbb90f41ee5e6f730ab8f /drivers/pwm | |
| parent | pwm: tegra: Don't modify HW state in .remove callback (diff) | |
| download | linux-dev-3b8b571fcc49e794703eb01a97e9ed8b85e88304.tar.xz linux-dev-3b8b571fcc49e794703eb01a97e9ed8b85e88304.zip | |
pwm: tegra: Don't needlessly enable and disable the clock in .remove()
There is no reason to enable the PWM clock just to assert the reset
control. (If the reset control depends on the clock this is a bug and
probably it doesn't because in .probe() the reset is deasserted without
the clock being enabled.)
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm')
| -rw-r--r-- | drivers/pwm/pwm-tegra.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c index a051cf43e7d7..e865743e5989 100644 --- a/drivers/pwm/pwm-tegra.c +++ b/drivers/pwm/pwm-tegra.c @@ -300,14 +300,8 @@ static int tegra_pwm_probe(struct platform_device *pdev) static int tegra_pwm_remove(struct platform_device *pdev) { struct tegra_pwm_chip *pc = platform_get_drvdata(pdev); - int err; - - err = clk_prepare_enable(pc->clk); - if (err < 0) - return err; reset_control_assert(pc->rst); - clk_disable_unprepare(pc->clk); return pwmchip_remove(&pc->chip); } |