diff options
| author |   yu kuai <yukuai3@huawei.com> | 2020-01-20 19:51:43 +0800 |
|---|---|---|
| committer |   Thierry Reding <thierry.reding@gmail.com> | 2020-01-20 15:40:49 +0100 |
| commit | 9871abffc81048e20f02e15d6aa4558a44ad53ea (patch) | |
| tree | 91788d3bbf5823872ca3294a52cb1108e9e79984 /drivers/pwm | |
| parent | pwm: sun4i: Initialize variables before use (diff) | |
| download | linux-dev-9871abffc81048e20f02e15d6aa4558a44ad53ea.tar.xz linux-dev-9871abffc81048e20f02e15d6aa4558a44ad53ea.zip | |
pwm: Remove set but not set variable 'pwm'
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/pwm/pwm-pca9685.c: In function ‘pca9685_pwm_gpio_free’:
drivers/pwm/pwm-pca9685.c:162:21: warning: variable ‘pwm’ set but not used [-Wunused-but-set-variable]
It is never used, and so can be removed. In that case, hold and release
the lock 'pca->lock' can be removed since nothing will be done between
them.
Fixes: e926b12c611c ("pwm: Clear chip_data in pwm_put()")
Signed-off-by: yu kuai <yukuai3@huawei.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm')
| -rw-r--r-- | drivers/pwm/pwm-pca9685.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c index 168684b02ebc..b07bdca3d510 100644 --- a/drivers/pwm/pwm-pca9685.c +++ b/drivers/pwm/pwm-pca9685.c @@ -159,13 +159,9 @@ static void pca9685_pwm_gpio_set(struct gpio_chip *gpio, unsigned int offset, static void pca9685_pwm_gpio_free(struct gpio_chip *gpio, unsigned int offset) { struct pca9685 *pca = gpiochip_get_data(gpio); - struct pwm_device *pwm; pca9685_pwm_gpio_set(gpio, offset, 0); pm_runtime_put(pca->chip.dev); - mutex_lock(&pca->lock); - pwm = &pca->chip.pwms[offset]; - mutex_unlock(&pca->lock); } static int pca9685_pwm_gpio_get_direction(struct gpio_chip *chip, |