diff options
| author |   Qinglang Miao <miaoqinglang@huawei.com> | 2020-09-19 09:22:52 +0800 |
|---|---|---|
| committer |   Borislav Petkov <bp@suse.de> | 2020-09-25 19:05:31 +0200 |
| commit | 4bd442e9a8388e8ec4ba7cf23a4774989d93b78e (patch) | |
| tree | 4eee6cdb04857c70e90487344ad109471a1ed924 /drivers/ras | |
| parent | x86/mce: Annotate mce_rd/wrmsrl() with noinstr (diff) | |
| download | linux-dev-4bd442e9a8388e8ec4ba7cf23a4774989d93b78e.tar.xz linux-dev-4bd442e9a8388e8ec4ba7cf23a4774989d93b78e.zip | |
RAS/CEC: Convert to DEFINE_SHOW_ATTRIBUTE()
Use the DEFINE_SHOW_ATTRIBUTE() macro and simplify the code.
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200919012252.171437-1-miaoqinglang@huawei.com
Diffstat (limited to 'drivers/ras')
| -rw-r--r-- | drivers/ras/cec.c | 17 |
1 files changed, 3 insertions, 14 deletions
diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c index 6939aa5b3dc7..ddecf25b5dd4 100644 --- a/drivers/ras/cec.c +++ b/drivers/ras/cec.c @@ -435,7 +435,7 @@ DEFINE_DEBUGFS_ATTRIBUTE(action_threshold_ops, u64_get, action_threshold_set, "% static const char * const bins[] = { "00", "01", "10", "11" }; -static int array_dump(struct seq_file *m, void *v) +static int array_show(struct seq_file *m, void *v) { struct ce_array *ca = &ce_arr; int i; @@ -467,18 +467,7 @@ static int array_dump(struct seq_file *m, void *v) return 0; } -static int array_open(struct inode *inode, struct file *filp) -{ - return single_open(filp, array_dump, NULL); -} - -static const struct file_operations array_ops = { - .owner = THIS_MODULE, - .open = array_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE(array); static int __init create_debugfs_nodes(void) { @@ -513,7 +502,7 @@ static int __init create_debugfs_nodes(void) goto err; } - array = debugfs_create_file("array", S_IRUSR, d, NULL, &array_ops); + array = debugfs_create_file("array", S_IRUSR, d, NULL, &array_fops); if (!array) { pr_warn("Error creating array debugfs node!\n"); goto err; |