diff options
| author |   Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-04-20 21:31:51 +0200 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2021-04-21 15:54:56 +0100 |
| commit | 8a065ce92b218e453742b745162d75a6f86fb768 (patch) | |
| tree | 6b30d941c7566f760de8f29a41e81ac5888cd08e /drivers/regulator/of_regulator.c | |
| parent | regulator: core.c: Fix indentation of comment (diff) | |
| download | linux-dev-8a065ce92b218e453742b745162d75a6f86fb768.tar.xz linux-dev-8a065ce92b218e453742b745162d75a6f86fb768.zip | |
regulator: Avoid a double 'of_node_get' in 'regulator_of_get_init_node()'
'for_each_available_child_of_node()' already performs an 'of_node_get()'
on child, so there is no need to perform another one before returning.
Otherwise, a double 'get' is performed and a resource may never be
released.
Fixes: 925c85e21ed8 ("regulator: Factor out location of init data OF node")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/a79f0068812b89ff412d572a1171f22109c24132.1618947049.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator/of_regulator.c')
| -rw-r--r-- | drivers/regulator/of_regulator.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c index 564f928eb1db..49f6c05fee34 100644 --- a/drivers/regulator/of_regulator.c +++ b/drivers/regulator/of_regulator.c @@ -422,7 +422,11 @@ device_node *regulator_of_get_init_node(struct device *dev, if (!strcmp(desc->of_match, name)) { of_node_put(search); - return of_node_get(child); + /* + * 'of_node_get(child)' is already performed by the + * for_each loop. + */ + return child; } } |