diff options
| author |   Yang Li <yang.lee@linux.alibaba.com> | 2021-02-26 09:39:35 +0800 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2021-03-10 12:47:47 +0000 |
| commit | 45ee8b79d67905ac57408b30314757981531def9 (patch) | |
| tree | e7ddf981a334b2ab6eea5fcfb94e471011699618 /drivers/regulator/scmi-regulator.c | |
| parent | regulator: pf8x00: Use regulator_map_voltage_ascend for pf8x00_buck7_ops (diff) | |
| download | linux-dev-45ee8b79d67905ac57408b30314757981531def9.tar.xz linux-dev-45ee8b79d67905ac57408b30314757981531def9.zip | |
regulator: add missing call to of_node_put()
In one of the error paths of the for_each_child_of_node() loop,
add missing call to of_node_put().
Fix the following coccicheck warning:
./drivers/regulator/scmi-regulator.c:343:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 347.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/1614303575-27436-1-git-send-email-yang.lee@linux.alibaba.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator/scmi-regulator.c')
| -rw-r--r-- | drivers/regulator/scmi-regulator.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/regulator/scmi-regulator.c b/drivers/regulator/scmi-regulator.c index 0e8b3caa8146..a917c81e99fa 100644 --- a/drivers/regulator/scmi-regulator.c +++ b/drivers/regulator/scmi-regulator.c @@ -343,8 +343,10 @@ static int scmi_regulator_probe(struct scmi_device *sdev) for_each_child_of_node(np, child) { ret = process_scmi_regulator_of_node(sdev, child, rinfo); /* abort on any mem issue */ - if (ret == -ENOMEM) + if (ret == -ENOMEM) { + of_node_put(child); return ret; + } } /* |