diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2019-08-08 13:33:35 +0300 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2019-08-08 20:41:09 +0100 |
| commit | 7352e72a513fd2757b2fda695a349d86faa4c94e (patch) | |
| tree | e3222620abf2b33cb4244913ea4c58bf67a653ef /drivers/regulator/slg51000-regulator.c | |
| parent | regulator: of: Add of_node_put() before return in function (diff) | |
| download | linux-dev-7352e72a513fd2757b2fda695a349d86faa4c94e.tar.xz linux-dev-7352e72a513fd2757b2fda695a349d86faa4c94e.zip | |
regulator: slg51000: Fix a couple NULL vs IS_ERR() checks
The devm_gpiod_get_from_of_node() function never returns NULL, it
returns error pointers on error.
Fixes: a867bde3dd03 ("regulator: slg51000: add slg51000 regulator driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20190808103335.GD30506@mwanda
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator/slg51000-regulator.c')
| -rw-r--r-- | drivers/regulator/slg51000-regulator.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/regulator/slg51000-regulator.c b/drivers/regulator/slg51000-regulator.c index 04b732991d69..4d859fef55e6 100644 --- a/drivers/regulator/slg51000-regulator.c +++ b/drivers/regulator/slg51000-regulator.c @@ -205,7 +205,7 @@ static int slg51000_of_parse_cb(struct device_node *np, ena_gpiod = devm_gpiod_get_from_of_node(chip->dev, np, "enable-gpios", 0, gflags, "gpio-en-ldo"); - if (ena_gpiod) { + if (!IS_ERR(ena_gpiod)) { config->ena_gpiod = ena_gpiod; devm_gpiod_unhinge(chip->dev, config->ena_gpiod); } @@ -459,7 +459,7 @@ static int slg51000_i2c_probe(struct i2c_client *client, GPIOD_OUT_HIGH | GPIOD_FLAGS_BIT_NONEXCLUSIVE, "slg51000-cs"); - if (cs_gpiod) { + if (!IS_ERR(cs_gpiod)) { dev_info(dev, "Found chip selector property\n"); chip->cs_gpiod = cs_gpiod; } |