diff options
| author |   Steve Twiss <stwiss.opensource@diasemi.com> | 2019-02-26 15:54:01 +0000 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2019-03-13 15:13:16 +0000 |
| commit | 8be64b6d87bd47d81753b60ddafe70102ebfd76b (patch) | |
| tree | f919aaf8d41a3535528872359dce95a00352cb5e /drivers/regulator/wm831x-ldo.c | |
| parent | regulator: wm831x isink: Fix notifier mutex lock warning (diff) | |
| download | linux-dev-8be64b6d87bd47d81753b60ddafe70102ebfd76b.tar.xz linux-dev-8be64b6d87bd47d81753b60ddafe70102ebfd76b.zip | |
regulator: wm831x ldo: Fix notifier mutex lock warning
The mutex for the regulator_dev must be controlled by the caller of
the regulator_notifier_call_chain(), as described in the comment
for that function.
Failure to mutex lock and unlock surrounding the notifier call results
in a kernel WARN_ON_ONCE() which will dump a backtrace for the
regulator_notifier_call_chain() when that function call is first made.
The mutex can be controlled using the regulator_lock/unlock() API.
Fixes: d1c6b4fe668b ("regulator: Add WM831x LDO support")
Suggested-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator/wm831x-ldo.c')
| -rw-r--r-- | drivers/regulator/wm831x-ldo.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/regulator/wm831x-ldo.c b/drivers/regulator/wm831x-ldo.c index e4a6f888484e..fcd038e7cd80 100644 --- a/drivers/regulator/wm831x-ldo.c +++ b/drivers/regulator/wm831x-ldo.c @@ -51,9 +51,11 @@ static irqreturn_t wm831x_ldo_uv_irq(int irq, void *data) { struct wm831x_ldo *ldo = data; + regulator_lock(ldo->regulator); regulator_notifier_call_chain(ldo->regulator, REGULATOR_EVENT_UNDER_VOLTAGE, NULL); + regulator_unlock(ldo->regulator); return IRQ_HANDLED; } |