diff options
| author |   Patrick Rudolph <patrick.rudolph@9elements.com> | 2022-09-09 14:59:53 +0200 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2022-09-09 22:27:10 +0100 |
| commit | 8d8e16592022c9650df8aedfe6552ed478d7135b (patch) | |
| tree | 3c556b1808d21ec2cd299b632375e920897d1f12 /drivers/regulator | |
| parent | regulator: dt-bindings: qcom,rpmh: Indicate regulator-allow-set-load dependencies (diff) | |
| download | linux-dev-8d8e16592022c9650df8aedfe6552ed478d7135b.tar.xz linux-dev-8d8e16592022c9650df8aedfe6552ed478d7135b.zip | |
regulator: core: Prevent integer underflow
By using a ratio of delay to poll_enabled_time that is not integer
time_remaining underflows and does not exit the loop as expected.
As delay could be derived from DT and poll_enabled_time is defined
in the driver this can easily happen.
Use a signed iterator to make sure that the loop exits once
the remaining time is negative.
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Link: https://lore.kernel.org/r/20220909125954.577669-1-patrick.rudolph@9elements.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator')
| -rw-r--r-- | drivers/regulator/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index a8dab5a93607..28879f8974d9 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2699,7 +2699,7 @@ static int _regulator_do_enable(struct regulator_dev *rdev) * return -ETIMEDOUT. */ if (rdev->desc->poll_enabled_time) { - unsigned int time_remaining = delay; + int time_remaining = delay; while (time_remaining > 0) { _regulator_delay_helper(rdev->desc->poll_enabled_time); |