diff options
| author |   Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-08-04 21:50:23 +0530 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2019-08-05 16:28:14 +0100 |
| commit | db2a17320a25a63b46ddb081a306af9ded1b906e (patch) | |
| tree | e39348dae3b05d4db6928aff87c883df5c4edcc0 /drivers/regulator | |
| parent | regulator: Remove dev_err() usage after platform_get_irq() (diff) | |
| download | linux-dev-db2a17320a25a63b46ddb081a306af9ded1b906e.tar.xz linux-dev-db2a17320a25a63b46ddb081a306af9ded1b906e.zip | |
regulator: core: Add of_node_put() before return
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return in
two places.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190804162023.5673-1-nishkadg.linux@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator')
| -rw-r--r-- | drivers/regulator/core.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index e0c0cf462004..7a5d52948703 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -380,9 +380,12 @@ static struct device_node *of_get_child_regulator(struct device_node *parent, if (!regnode) { regnode = of_get_child_regulator(child, prop_name); - if (regnode) + if (regnode) { + of_node_put(child); return regnode; + } } else { + of_node_put(child); return regnode; } } |