diff options
| author |   Suman Anna <s-anna@ti.com> | 2018-09-14 19:37:22 -0500 |
|---|---|---|
| committer |   Bjorn Andersson <bjorn.andersson@linaro.org> | 2018-10-05 23:04:20 -0700 |
| commit | faeadbb64094757150a8c2a3175ca418dbdd472c (patch) | |
| tree | 9644cf26f3e593b01d8406477aa7a53b413615c0 /drivers/remoteproc | |
| parent | remoteproc: qcom: q6v5-pil: Add PDC reset for modem on SDM845 SoCs (diff) | |
| download | linux-dev-faeadbb64094757150a8c2a3175ca418dbdd472c.tar.xz linux-dev-faeadbb64094757150a8c2a3175ca418dbdd472c.zip | |
remoteproc: Check for NULL firmwares in sysfs interface
The remoteproc framework provides a sysfs file 'firmware'
for modifying the firmware image name from userspace. Add
an additional check to ensure NULL firmwares are errored
out right away, rather than getting a delayed error while
requesting a firmware during the start of a remoteproc
later on.
Tested-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Diffstat (limited to 'drivers/remoteproc')
| -rw-r--r-- | drivers/remoteproc/remoteproc_sysfs.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c index 47be411400e5..3a4c3d7cafca 100644 --- a/drivers/remoteproc/remoteproc_sysfs.c +++ b/drivers/remoteproc/remoteproc_sysfs.c @@ -48,6 +48,11 @@ static ssize_t firmware_store(struct device *dev, } len = strcspn(buf, "\n"); + if (!len) { + dev_err(dev, "can't provide a NULL firmware\n"); + err = -EINVAL; + goto out; + } p = kstrndup(buf, len, GFP_KERNEL); if (!p) { |