diff options
| author |   Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn> | 2022-02-16 03:07:20 +0000 |
|---|---|---|
| committer |   Bjorn Andersson <bjorn.andersson@linaro.org> | 2022-03-11 14:24:55 -0600 |
| commit | 18fc82d6e899be54fcf43b28e588e28f09c8810f (patch) | |
| tree | e6f4a7766c2b5754d8e726903075289b02c3c4a5 /drivers/rpmsg/qcom_glink_native.c | |
| parent | rpmsg: smd: allow opening rpm_requests even if already opened (diff) | |
| download | linux-dev-18fc82d6e899be54fcf43b28e588e28f09c8810f.tar.xz linux-dev-18fc82d6e899be54fcf43b28e588e28f09c8810f.zip | |
rpmsg: use struct_size over open coded arithmetic
Replace zero-length array with flexible-array member and make use
of the struct_size() helper in kzalloc(). For example:
struct glink_defer_cmd {
struct list_head node;
struct glink_msg msg;
u8 data[];
};
Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220216030720.1839503-1-chi.minghao@zte.com.cn
Diffstat (limited to 'drivers/rpmsg/qcom_glink_native.c')
| -rw-r--r-- | drivers/rpmsg/qcom_glink_native.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 1030cfa80e04..f4f4e392d0d1 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -792,7 +792,7 @@ static int qcom_glink_rx_defer(struct qcom_glink *glink, size_t extra) return -ENXIO; } - dcmd = kzalloc(sizeof(*dcmd) + extra, GFP_ATOMIC); + dcmd = kzalloc(struct_size(dcmd, data, extra), GFP_ATOMIC); if (!dcmd) return -ENOMEM; |