diff options
| author |   Bartosz Golaszewski <bgolaszewski@baylibre.com> | 2020-11-09 17:34:08 +0100 |
|---|---|---|
| committer |   Alexandre Belloni <alexandre.belloni@bootlin.com> | 2020-11-19 12:50:12 +0100 |
| commit | fdcfd854333be5b30377dc5daa9cd0fa1643a979 (patch) | |
| tree | 89b755560a425f0eb332a86037e2b6d429b7fb5a /drivers/rtc/rtc-rv3032.c | |
| parent | rtc: nvmem: emit an error message when nvmem registration fails (diff) | |
| download | linux-dev-fdcfd854333be5b30377dc5daa9cd0fa1643a979.tar.xz linux-dev-fdcfd854333be5b30377dc5daa9cd0fa1643a979.zip | |
rtc: rework rtc_register_device() resource management
rtc_register_device() is a managed interface but it doesn't use devres
by itself - instead it marks an rtc_device as "registered" and the devres
callback for devm_rtc_allocate_device() takes care of resource release.
This doesn't correspond with the design behind devres where managed
structures should not be aware of being managed. The correct solution
here is to register a separate devres callback for unregistering the
device.
While at it: rename rtc_register_device() to devm_rtc_register_device()
and add it to the list of managed interfaces in devres.rst. This way we
can avoid any potential confusion of driver developers who may expect
there to exist a corresponding unregister function.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl
Diffstat (limited to 'drivers/rtc/rtc-rv3032.c')
| -rw-r--r-- | drivers/rtc/rtc-rv3032.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/rtc/rtc-rv3032.c b/drivers/rtc/rtc-rv3032.c index ed9cba3292e6..c9bcea727757 100644 --- a/drivers/rtc/rtc-rv3032.c +++ b/drivers/rtc/rtc-rv3032.c @@ -885,7 +885,7 @@ static int rv3032_probe(struct i2c_client *client) rv3032->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; rv3032->rtc->range_max = RTC_TIMESTAMP_END_2099; rv3032->rtc->ops = &rv3032_rtc_ops; - ret = rtc_register_device(rv3032->rtc); + ret = devm_rtc_register_device(rv3032->rtc); if (ret) return ret; |