diff options
| author |   Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-02-18 23:36:18 +0100 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-03-01 10:49:40 +0100 |
| commit | bd7f4e7598921506c2ae343954fdbb764840921b (patch) | |
| tree | 5c753e608d1aa8a16cf687de095994190f19adc9 /drivers/rtc/rtc-stk17ta8.c | |
| parent | rtc: rs5c348: let the core handle invalid time (diff) | |
| download | linux-dev-bd7f4e7598921506c2ae343954fdbb764840921b.tar.xz linux-dev-bd7f4e7598921506c2ae343954fdbb764840921b.zip | |
rtc: stk17ta8: let the core handle invalid time
Returning a valid time when the time is invalid is a bad practice, because
then userspace is not able to react on the information. Also, it doesn't
make sense to return epoch because it is already the default time.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Diffstat (limited to 'drivers/rtc/rtc-stk17ta8.c')
| -rw-r--r-- | drivers/rtc/rtc-stk17ta8.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/rtc/rtc-stk17ta8.c b/drivers/rtc/rtc-stk17ta8.c index 01a3bef77aa5..e70b78d17a98 100644 --- a/drivers/rtc/rtc-stk17ta8.c +++ b/drivers/rtc/rtc-stk17ta8.c @@ -129,10 +129,6 @@ static int stk17ta8_rtc_read_time(struct device *dev, struct rtc_time *tm) /* year is 1900 + tm->tm_year */ tm->tm_year = bcd2bin(year) + bcd2bin(century) * 100 - 1900; - if (rtc_valid_tm(tm) < 0) { - dev_err(dev, "retrieved date/time is not valid.\n"); - rtc_time_to_tm(0, tm); - } return 0; } |