diff options
| author |   Christoph Hellwig <hch@lst.de> | 2022-04-18 06:53:10 +0200 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2022-05-03 10:38:50 -0600 |
| commit | c3f765299632727fa5ea5a0acf118665227a4f1a (patch) | |
| tree | f2149108cd358668be0a07acdd76eb56c9b75e88 /drivers/s390/block | |
| parent | raid5: don't set the discard_alignment queue limit (diff) | |
| download | linux-dev-c3f765299632727fa5ea5a0acf118665227a4f1a.tar.xz linux-dev-c3f765299632727fa5ea5a0acf118665227a4f1a.zip | |
dasd: don't set the discard_alignment queue limit
The discard_alignment queue limit is named a bit misleading means the
offset into the block device at which the discard granularity starts.
Setting it to PAGE_SIZE while the discard granularity is the block size
that is smaller or the same as PAGE_SIZE as done by dasd is mostly
harmless but also useless.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/r/20220418045314.360785-8-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/s390/block')
| -rw-r--r-- | drivers/s390/block/dasd_fba.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/s390/block/dasd_fba.c b/drivers/s390/block/dasd_fba.c index 8bd5665db919..60be7f7bf2d1 100644 --- a/drivers/s390/block/dasd_fba.c +++ b/drivers/s390/block/dasd_fba.c @@ -782,7 +782,6 @@ static void dasd_fba_setup_blk_queue(struct dasd_block *block) blk_queue_segment_boundary(q, PAGE_SIZE - 1); q->limits.discard_granularity = logical_block_size; - q->limits.discard_alignment = PAGE_SIZE; /* Calculate max_discard_sectors and make it PAGE aligned */ max_bytes = USHRT_MAX * logical_block_size; |