diff options
| author |   Julian Wiedmann <jwi@linux.ibm.com> | 2018-11-02 19:04:10 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-11-03 10:44:05 -0700 |
| commit | 30356d08159d7899438e94503ae322a8b881e205 (patch) | |
| tree | df4aaea6626e6a7367f782ebd43f3223f1f01b95 /drivers/s390/net/qeth_core.h | |
| parent | s390/qeth: fix HiperSockets sniffer (diff) | |
| download | linux-dev-30356d08159d7899438e94503ae322a8b881e205.tar.xz linux-dev-30356d08159d7899438e94503ae322a8b881e205.zip | |
s390/qeth: unregister netdevice only when registered
qeth only registers its netdevice when the qeth device is first set
online. Thus a device that has never been set online will trigger
a WARN ("network todo 'hsi%d' but state 0") in unregister_netdev() when
removed.
Fix this by protecting the unregister step, just like we already protect
against repeated registering of the netdevice.
Fixes: d3d1b205e89f ("s390/qeth: allocate netdevice early")
Reported-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/s390/net/qeth_core.h')
| -rw-r--r-- | drivers/s390/net/qeth_core.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/s390/net/qeth_core.h b/drivers/s390/net/qeth_core.h index 884ba9dfb341..b3a0b8838d2f 100644 --- a/drivers/s390/net/qeth_core.h +++ b/drivers/s390/net/qeth_core.h @@ -843,6 +843,11 @@ struct qeth_trap_id { /*some helper functions*/ #define QETH_CARD_IFNAME(card) (((card)->dev)? (card)->dev->name : "") +static inline bool qeth_netdev_is_registered(struct net_device *dev) +{ + return dev->netdev_ops != NULL; +} + static inline void qeth_scrub_qdio_buffer(struct qdio_buffer *buf, unsigned int elements) { |