diff options
| author |   Julian Wiedmann <jwi@linux.ibm.com> | 2019-12-18 16:32:27 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-12-20 21:00:27 -0800 |
| commit | 0f399305cd31e5c813086eaa264f7f47e205c10e (patch) | |
| tree | 7231f4b20bce88afee5553066fe085a914fb400a /drivers/s390/net/qeth_l3_main.c | |
| parent | s390/qeth: handle error due to unsupported transport mode (diff) | |
| download | linux-dev-0f399305cd31e5c813086eaa264f7f47e205c10e.tar.xz linux-dev-0f399305cd31e5c813086eaa264f7f47e205c10e.zip | |
s390/qeth: fix promiscuous mode after reset
When managing the promiscuous mode during an RX modeset, qeth caches the
current HW state to avoid repeated programming of the same state on each
modeset.
But while tearing down a device, we forget to clear the cached state. So
when the device is later set online again, the initial RX modeset
doesn't program the promiscuous mode since we believe it is already
enabled.
Fix this by clearing the cached state in the tear-down path.
Note that for the SBP variant of promiscuous mode, this accidentally
works right now because we unconditionally restore the SBP role while
re-initializing.
Fixes: 4a71df50047f ("qeth: new qeth device driver")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/s390/net/qeth_l3_main.c')
| -rw-r--r-- | drivers/s390/net/qeth_l3_main.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c index 27126330a4b0..04e301de376f 100644 --- a/drivers/s390/net/qeth_l3_main.c +++ b/drivers/s390/net/qeth_l3_main.c @@ -1314,6 +1314,7 @@ static void qeth_l3_stop_card(struct qeth_card *card) } flush_workqueue(card->event_wq); + card->info.promisc_mode = 0; } static void qeth_l3_set_promisc_mode(struct qeth_card *card) |