diff options
| author |   Julian Wiedmann <jwi@linux.ibm.com> | 2019-03-28 16:39:20 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-03-28 12:57:23 -0700 |
| commit | 5c0aebc6db8cf81c5dd888388dcb455beb1a87b8 (patch) | |
| tree | a0e4cc11564301962f66f9604d1fe8446f6ab463 /drivers/s390/net/qeth_l3_main.c | |
| parent | s390/qeth: defer RX modesetting (diff) | |
| download | linux-dev-5c0aebc6db8cf81c5dd888388dcb455beb1a87b8.tar.xz linux-dev-5c0aebc6db8cf81c5dd888388dcb455beb1a87b8.zip | |
s390/qeth: remove locking for RX modeset cache
The L2 and L3 .ndo_set_rx_mode callbacks maintain an address cache
to decide which addresses have changed since the last modeset.
When the card is set offline, qeth_l?_stop_card() drains this cache.
This happens only after 1) the net_device has been detached, and
2) any pending RX modeset has completed. Consequently we can access the
cache lock-free.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/s390/net/qeth_l3_main.c')
| -rw-r--r-- | drivers/s390/net/qeth_l3_main.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c index b6df38f092e6..7e32edac627b 100644 --- a/drivers/s390/net/qeth_l3_main.c +++ b/drivers/s390/net/qeth_l3_main.c @@ -274,12 +274,10 @@ static void qeth_l3_drain_rx_mode_cache(struct qeth_card *card) struct hlist_node *tmp; int i; - spin_lock_bh(&card->mclock); hash_for_each_safe(card->ip_mc_htable, i, tmp, addr, hnode) { hash_del(&addr->hnode); kfree(addr); } - spin_unlock_bh(&card->mclock); } static void qeth_l3_clear_ip_htable(struct qeth_card *card, int recover) @@ -1484,8 +1482,6 @@ static void qeth_l3_rx_mode_work(struct work_struct *work) QETH_CARD_TEXT(card, 3, "setmulti"); if (!card->options.sniffer) { - spin_lock_bh(&card->mclock); - qeth_l3_add_multicast_ipv4(card); qeth_l3_add_multicast_ipv6(card); @@ -1513,8 +1509,6 @@ static void qeth_l3_rx_mode_work(struct work_struct *work) } } - spin_unlock_bh(&card->mclock); - if (!qeth_adp_supported(card, IPA_SETADP_SET_PROMISC_MODE)) return; } |