diff options
| author |   Julian Wiedmann <jwi@linux.ibm.com> | 2019-12-23 15:03:26 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-12-24 22:41:06 -0800 |
| commit | 0b698c838e84149b690c7e979f78cccb6f8aa4b9 (patch) | |
| tree | 7baf89da5adc33370c47957670ecfa5ad3798070 /drivers/s390/net | |
| parent | s390/qeth: vnicc Fix init to default (diff) | |
| download | linux-dev-0b698c838e84149b690c7e979f78cccb6f8aa4b9.tar.xz linux-dev-0b698c838e84149b690c7e979f78cccb6f8aa4b9.zip | |
s390/qeth: fix initialization on old HW
I stumbled over an old OSA model that claims to support DIAG_ASSIST,
but then rejects the cmd to query its DIAG capabilities.
In the old code this was ok, as the returned raw error code was > 0.
Now that we translate the raw codes to errnos, the "rc < 0" causes us
to fail the initialization of the device.
The fix is trivial: don't bail out when the DIAG query fails. Such an
error is not critical, we can still use the device (with a slightly
reduced set of features).
Fixes: 742d4d40831d ("s390/qeth: convert remaining legacy cmd callbacks")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/s390/net')
| -rw-r--r-- | drivers/s390/net/qeth_core_main.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index c64ef55f0dff..29facb913671 100644 --- a/drivers/s390/net/qeth_core_main.c +++ b/drivers/s390/net/qeth_core_main.c @@ -5026,10 +5026,8 @@ retriable: } if (qeth_adp_supported(card, IPA_SETADP_SET_DIAG_ASSIST)) { rc = qeth_query_setdiagass(card); - if (rc < 0) { + if (rc) QETH_CARD_TEXT_(card, 2, "8err%d", rc); - goto out; - } } if (!qeth_is_diagass_supported(card, QETH_DIAGS_CMD_TRAP) || |