diff options
| author |   Wei Yongjun <weiyongjun1@huawei.com> | 2020-05-13 09:42:29 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-05-13 12:14:51 -0700 |
| commit | 29b74cb75e3572d83708745e81e24d37837415f9 (patch) | |
| tree | e93702f52638328a02ebc46360f18cf2e38b2e91 /drivers/s390 | |
| parent | netlabel: cope with NULL catmap (diff) | |
| download | linux-dev-29b74cb75e3572d83708745e81e24d37837415f9.tar.xz linux-dev-29b74cb75e3572d83708745e81e24d37837415f9.zip | |
s390/ism: fix error return code in ism_probe()
Fix to return negative error code -ENOMEM from the smcd_alloc_dev()
error handling case instead of 0, as done elsewhere in this function.
Fixes: 684b89bc39ce ("s390/ism: add device driver for internal shared memory")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/s390')
| -rw-r--r-- | drivers/s390/net/ism_drv.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/s390/net/ism_drv.c b/drivers/s390/net/ism_drv.c index c75112ee7b97..c7fade836d83 100644 --- a/drivers/s390/net/ism_drv.c +++ b/drivers/s390/net/ism_drv.c @@ -521,8 +521,10 @@ static int ism_probe(struct pci_dev *pdev, const struct pci_device_id *id) ism->smcd = smcd_alloc_dev(&pdev->dev, dev_name(&pdev->dev), &ism_ops, ISM_NR_DMBS); - if (!ism->smcd) + if (!ism->smcd) { + ret = -ENOMEM; goto err_resource; + } ism->smcd->priv = ism; ret = ism_dev_init(ism); |