diff options
| author |   Julian Wiedmann <jwi@linux.vnet.ibm.com> | 2017-10-18 17:40:23 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-10-20 13:11:05 +0100 |
| commit | 864c17c3d83be6a1f6a2888566e93e114986abca (patch) | |
| tree | 4b1259cbb2a4434eb9baf8cbf4b49681601cc807 /drivers/s390 | |
| parent | s390/qeth: consolidate skb allocation (diff) | |
| download | linux-dev-864c17c3d83be6a1f6a2888566e93e114986abca.tar.xz linux-dev-864c17c3d83be6a1f6a2888566e93e114986abca.zip | |
s390/qeth: try harder to get packets from RX buffer
Current code bails out when two subsequent buffer elements hold
insufficient data to contain a qeth_hdr packet descriptor.
This seems reasonable, but it would be legal for quirky hardware to
leave a few elements empty and then present packets in a subsequent
element. These packets would currently be dropped.
So make sure to check all buffer elements, until we hit the LAST_ENTRY
indication.
Signed-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/s390')
| -rw-r--r-- | drivers/s390/net/qeth_core_main.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index 23b439fb5f2c..8855bc8534d2 100644 --- a/drivers/s390/net/qeth_core_main.c +++ b/drivers/s390/net/qeth_core_main.c @@ -5214,13 +5214,11 @@ struct sk_buff *qeth_core_get_next_skb(struct qeth_card *card, int use_rx_sg = 0; /* qeth_hdr must not cross element boundaries */ - if (element->length < offset + sizeof(struct qeth_hdr)) { + while (element->length < offset + sizeof(struct qeth_hdr)) { if (qeth_is_last_sbale(element)) return NULL; element++; offset = 0; - if (element->length < sizeof(struct qeth_hdr)) - return NULL; } *hdr = element->addr + offset; |