aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/aacraid/comminit.c
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2013-01-21 14:02:49 +0100
committerJames Bottomley <JBottomley@Parallels.com>2013-01-30 14:04:54 +1100
commitb0d5e15cc4d76efacdfe8d974f50d2afc25123fe (patch)
tree4e2a395cb3914f6554b569d0b69acc71fec7512a /drivers/scsi/aacraid/comminit.c
parent[SCSI] qla4xxx: Update driver version to 5.03.00-k4 (diff)
downloadlinux-dev-b0d5e15cc4d76efacdfe8d974f50d2afc25123fe.tar.xz
linux-dev-b0d5e15cc4d76efacdfe8d974f50d2afc25123fe.zip
[SCSI] bnx2fc: adjust duplicate test
Delete successive tests to the same location. The code tested the result of a previous allocation, that itself was already tested. It is changed to test the result of the most recent allocation. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @s exists@ local idexpression y; expression x,e; @@ *if ( \(x == NULL\|IS_ERR(x)\|y != 0\) ) { ... when forall return ...; } ... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\) when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\) *if ( \(x == NULL\|IS_ERR(x)\|y != 0\) ) { ... when forall return ...; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Acked-by: Bhanu Prakash Gollapudi <bprakash@broadcom.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/aacraid/comminit.c')
0 files changed, 0 insertions, 0 deletions