diff options
| author |   Finn Thain <fthain@telegraphics.com.au> | 2014-11-12 16:11:52 +1100 |
|---|---|---|
| committer |   Christoph Hellwig <hch@lst.de> | 2014-11-20 09:11:05 +0100 |
| commit | 4d3d2a54f731aa25f66adcf934ba9a55ca8204d4 (patch) | |
| tree | 99ddb1b68ec6d13a81550f07f4d877b1bea81df4 /drivers/scsi/dtc.c | |
| parent | ncr5380: Remove useless prototypes (diff) | |
| download | linux-dev-4d3d2a54f731aa25f66adcf934ba9a55ca8204d4.tar.xz linux-dev-4d3d2a54f731aa25f66adcf934ba9a55ca8204d4.zip | |
ncr5380: Remove more useless prototypes
Make use of the host template static initializer instead of assigning
handlers at run-time. Move __maybe_unused qualifiers from declarations
to definitions. Move the atari_scsi_bus_reset() wrapper after the
definition of NCR5380_bus_reset(). All of the host template handler
prototypes are now redundant so remove them.
The write_info() handler is only relevant to drivers using PSEUDO_DMA so
this patch fixes the compiler warning in atari_NCR5380.c and sun3_NCR5380.c:
CC drivers/scsi/atari_scsi.o
drivers/scsi/NCR5380.h:329: warning: 'NCR5380_write_info' declared 'static' but never defined
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/dtc.c')
| -rw-r--r-- | drivers/scsi/dtc.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c index f271fc5f6b82..e890b08efbd8 100644 --- a/drivers/scsi/dtc.c +++ b/drivers/scsi/dtc.c @@ -219,10 +219,6 @@ static int __init dtc_detect(struct scsi_host_template * tpnt) void __iomem *base; int sig, count; - tpnt->proc_name = "dtc3x80"; - tpnt->show_info = dtc_show_info; - tpnt->write_info = dtc_write_info; - for (count = 0; current_override < NO_OVERRIDES; ++current_override) { addr = 0; base = NULL; @@ -477,6 +473,9 @@ static struct scsi_host_template driver_template = { .name = "DTC 3180/3280 ", .detect = dtc_detect, .release = dtc_release, + .proc_name = "dtc3x80", + .show_info = dtc_show_info, + .write_info = dtc_write_info, .queuecommand = dtc_queue_command, .eh_abort_handler = dtc_abort, .eh_bus_reset_handler = dtc_bus_reset, |