aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/dtc.c
diff options
context:
space:
mode:
authorFinn Thain <fthain@telegraphics.com.au>2016-01-03 16:05:39 +1100
committerMartin K. Petersen <martin.petersen@oracle.com>2016-01-06 21:43:00 -0500
commitd1af9c7f4a69824440d2d755ddc3b861712ef024 (patch)
tree9bc2ce3c4a693a566352d46cb5ebaa4875fa3ea3 /drivers/scsi/dtc.c
parentncr5380: Standardize work queueing algorithm (diff)
downloadlinux-dev-d1af9c7f4a69824440d2d755ddc3b861712ef024.tar.xz
linux-dev-d1af9c7f4a69824440d2d755ddc3b861712ef024.zip
ncr5380: Remove UNSAFE macro
Configuring core drivers using macros like this one prevents re-unifying the core driver forks, and prevents implementing the core driver as a library or a platform driver. The UNSAFE macro in particular is a poor workaround for the problem of interrupt latency. Releasing the locks complicates things because then we would have to handle the possibility of EH handler invocation during a PDMA transfer. The comments say that instead of using this macro, "you're going to be better off twiddling with transfersize". I agree. Remove this stuff. Signed-off-by: Finn Thain <fthain@telegraphics.com.au> Reviewed-by: Hannes Reinecke <hare@suse.com> Tested-by: Ondrej Zary <linux@rainbow-software.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/dtc.c')
-rw-r--r--drivers/scsi/dtc.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c
index 010d9b13aae7..60bffb34ecfb 100644
--- a/drivers/scsi/dtc.c
+++ b/drivers/scsi/dtc.c
@@ -1,7 +1,5 @@
-
#define PSEUDO_DMA
#define DONT_USE_INTR
-#define UNSAFE /* Leave interrupts enabled during pseudo-dma I/O */
#define DMA_WORKS_RIGHT