aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/hosts.c
diff options
context:
space:
mode:
authorBart Van Assche <bvanassche@acm.org>2021-10-07 13:46:11 -0700
committerMartin K. Petersen <martin.petersen@oracle.com>2021-10-16 21:31:43 -0400
commit11b68e36b16752ae3a48dc16229958ebc9bb324a (patch)
tree68983e3b0ee7514f52a56250d7b6a594151452ec /drivers/scsi/hosts.c
parentscsi: usb: Call scsi_done() directly (diff)
downloadlinux-dev-11b68e36b16752ae3a48dc16229958ebc9bb324a.tar.xz
linux-dev-11b68e36b16752ae3a48dc16229958ebc9bb324a.zip
scsi: core: Call scsi_done directly
Conditional statements are faster than indirect calls. Hence call scsi_done() directly. Since this patch removes the last user of the scsi_done member, also remove that data structure member. Link: https://lore.kernel.org/r/20211007204618.2196847-11-bvanassche@acm.org Reviewed-by: Benjamin Block <bblock@linux.ibm.com> Reviewed-by: Bean Huo <beanhuo@micron.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/hosts.c')
-rw-r--r--drivers/scsi/hosts.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index b8362700a9de..d78cec702596 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -667,7 +667,7 @@ static bool complete_all_cmds_iter(struct request *rq, void *data, bool rsvd)
scsi_dma_unmap(scmd);
scmd->result = 0;
set_host_byte(scmd, status);
- scmd->scsi_done(scmd);
+ scsi_done(scmd);
return true;
}