diff options
| author |   Tomas Henzl <thenzl@redhat.com> | 2015-01-23 16:41:20 -0600 |
|---|---|---|
| committer |   James Bottomley <JBottomley@Parallels.com> | 2015-02-02 09:57:35 -0800 |
| commit | 3b747298786355c6934b0892fc9ae4ca44105192 (patch) | |
| tree | 41042f1c5b23114634364961d2f38aa7c53225d4 /drivers/scsi/hpsa.c | |
| parent | hpsa: fix memory leak in kdump hard reset (diff) | |
| download | linux-dev-3b747298786355c6934b0892fc9ae4ca44105192.tar.xz linux-dev-3b747298786355c6934b0892fc9ae4ca44105192.zip | |
hpsa: turn off interrupts when kdump starts
Sometimes when the card is restarted it may cause -
"irq 16: nobody cared (try booting with the "irqpoll" option)"
that is likely caused so, that the card, after the hard reset
finishes, pulls on the irq. Disabling the ints before or after
the hpsa_kdump_hard_reset_controller fixes it.
At this point we can't know in which state the card is,
so using SA5_INTR_OFF + SA5_REPLY_INTR_MASK_OFFSET defines directly,
instead of the function the drivers provides, seems to be apropriate.
Reviewed-by: Scott Teel <scott.teel@pmcs.com>
Signed-off-by: Don Brace <don.brace@pmcs.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/hpsa.c')
| -rw-r--r-- | drivers/scsi/hpsa.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index d97f4555ab0f..9edacff962a3 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -6370,6 +6370,7 @@ static void hpsa_hba_inquiry(struct ctlr_info *h) static int hpsa_init_reset_devices(struct pci_dev *pdev) { int rc, i; + void __iomem *vaddr; if (!reset_devices) return 0; @@ -6393,6 +6394,14 @@ static int hpsa_init_reset_devices(struct pci_dev *pdev) pci_set_master(pdev); + vaddr = pci_ioremap_bar(pdev, 0); + if (vaddr == NULL) { + rc = -ENOMEM; + goto out_disable; + } + writel(SA5_INTR_OFF, vaddr + SA5_REPLY_INTR_MASK_OFFSET); + iounmap(vaddr); + /* Reset the controller with a PCI power-cycle or via doorbell */ rc = hpsa_kdump_hard_reset_controller(pdev); |