diff options
| author |   Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2016-11-30 15:28:55 -0600 |
|---|---|---|
| committer |   Martin K. Petersen <martin.petersen@oracle.com> | 2016-11-30 19:58:04 -0500 |
| commit | 9dadfb973f0d9396ef18f7ee0867fe9a165c03f4 (patch) | |
| tree | 769a3c0f66a3ce447f1bb94163c1cddf4c2d8ac0 /drivers/scsi/ipr.c | |
| parent | scsi: dpt_i2o: double free on error path (diff) | |
| download | linux-dev-9dadfb973f0d9396ef18f7ee0867fe9a165c03f4.tar.xz linux-dev-9dadfb973f0d9396ef18f7ee0867fe9a165c03f4.zip | |
scsi: ipr: Fix runaway IRQs when falling back from MSI to LSI
LSIs must be ack'ed with an MMIO otherwise they remain asserted
forever. This is controlled by the "clear_isr" flag.
While we set that flag properly when deciding initially whether to use
LSIs or MSIs, we fail to set it if we first chose MSIs, the test fails,
then fallback to LSIs.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/ipr.c')
| -rw-r--r-- | drivers/scsi/ipr.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c index 534dc3c877da..835c59c777f2 100644 --- a/drivers/scsi/ipr.c +++ b/drivers/scsi/ipr.c @@ -10157,6 +10157,7 @@ static int ipr_probe_ioa(struct pci_dev *pdev, pci_free_irq_vectors(pdev); ioa_cfg->nvectors = 1; + ioa_cfg->clear_isr = 1; break; default: goto out_msi_disable; |