diff options
| author |   James Smart <jsmart2021@gmail.com> | 2018-01-30 15:58:55 -0800 |
|---|---|---|
| committer |   Martin K. Petersen <martin.petersen@oracle.com> | 2018-02-12 11:43:23 -0500 |
| commit | 2289e9598dde9705400559ca2606fb8c145c34f0 (patch) | |
| tree | ea0532b891705ab8f5c5c899ece69ab84b6a5f70 /drivers/scsi/lpfc/lpfc_attr.c | |
| parent | scsi: lpfc: Fix soft lockup in lpfc worker thread during LIP testing (diff) | |
| download | linux-dev-2289e9598dde9705400559ca2606fb8c145c34f0.tar.xz linux-dev-2289e9598dde9705400559ca2606fb8c145c34f0.zip | |
scsi: lpfc: Fix issue_lip if link is disabled
The driver ignored checks on whether the link should be kept
administratively down after a link bounce. Correct the checks.
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/lpfc/lpfc_attr.c')
| -rw-r--r-- | drivers/scsi/lpfc/lpfc_attr.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index 06138b618220..e25e63eb5a53 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -911,7 +911,12 @@ lpfc_issue_lip(struct Scsi_Host *shost) LPFC_MBOXQ_t *pmboxq; int mbxstatus = MBXERR_ERROR; + /* + * If the link is offline, disabled or BLOCK_MGMT_IO + * it doesn't make any sense to allow issue_lip + */ if ((vport->fc_flag & FC_OFFLINE_MODE) || + (phba->hba_flag & LINK_DISABLED) || (phba->sli.sli_flag & LPFC_BLOCK_MGMT_IO)) return -EPERM; |