diff options
| author |   James Smart <james.smart@emulex.com> | 2013-10-10 12:24:07 -0400 |
|---|---|---|
| committer |   James Bottomley <JBottomley@Parallels.com> | 2013-10-25 09:58:18 +0100 |
| commit | 53151bbb83f11b358ac94eddd81347c581dc51ea (patch) | |
| tree | ffce8c5717d448789f1be3ac78c261b6d2d5a681 /drivers/scsi/lpfc/lpfc_sli.c | |
| parent | [SCSI] lpfc 8.3.43: Fixed spinlock hang. (diff) | |
| download | linux-dev-53151bbb83f11b358ac94eddd81347c581dc51ea.tar.xz linux-dev-53151bbb83f11b358ac94eddd81347c581dc51ea.zip | |
[SCSI] lpfc 8.3.43: Fixed not processing task management IOCB response status
This patch implements the changes requested by Jeremy Linton:
http://marc.info/?l=linux-scsi&m=136242124409687&w=2
The patch revises the command issuing behavior, detecting cases where the
Task Mgmt command may have completed but with a non-successful status, which it
previously treated as a successful TMF. The patch also corrects a flushing of
I/O that was done which should only be done on successful TMF completion.
Signed-off-by: James Smart <james.smart@emulex.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/lpfc/lpfc_sli.c')
| -rw-r--r-- | drivers/scsi/lpfc/lpfc_sli.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index a262d22bca44..8f580fda443f 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -10196,6 +10196,11 @@ lpfc_sli_issue_iocb_wait(struct lpfc_hba *phba, if (iocb_completed) { lpfc_printf_log(phba, KERN_INFO, LOG_SLI, "0331 IOCB wake signaled\n"); + /* Note: we are not indicating if the IOCB has a success + * status or not - that's for the caller to check. + * IOCB_SUCCESS means just that the command was sent and + * completed. Not that it completed successfully. + * */ } else if (timeleft == 0) { lpfc_printf_log(phba, KERN_ERR, LOG_SLI, "0338 IOCB wait timeout error - no " |