diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2020-12-09 17:03:11 +0300 |
|---|---|---|
| committer |   Martin K. Petersen <martin.petersen@oracle.com> | 2020-12-09 11:57:39 -0500 |
| commit | 8b3c8035297e71abb9e6d0f50ceab50d33c0d64b (patch) | |
| tree | d61a68d97c6329f53436f75cee60d2520780ee79 /drivers/scsi/mpt3sas | |
| parent | scsi: block: Do not accept any requests while suspended (diff) | |
| download | linux-dev-8b3c8035297e71abb9e6d0f50ceab50d33c0d64b.tar.xz linux-dev-8b3c8035297e71abb9e6d0f50ceab50d33c0d64b.zip | |
scsi: mpt3sas: Signedness bug in _base_get_diag_triggers()
The "trigger_flags" variable needs to be signed for the error checking to
work.
Link: https://lore.kernel.org/r/X9DZH37bYPHwSQRP@mwanda
Fixes: aec93e8e2385 ("scsi: mpt3sas: Add persistent trigger pages support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/mpt3sas')
| -rw-r--r-- | drivers/scsi/mpt3sas/mpt3sas_base.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index b129f3734ed0..26537d503a8b 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -5027,7 +5027,7 @@ _base_check_for_trigger_pages_support(struct MPT3SAS_ADAPTER *ioc) static void _base_get_diag_triggers(struct MPT3SAS_ADAPTER *ioc) { - u16 trigger_flags; + int trigger_flags; /* * Default setting of master trigger. |