diff options
| author |   Bart Van Assche <bvanassche@acm.org> | 2019-08-08 20:01:49 -0700 |
|---|---|---|
| committer |   Martin K. Petersen <martin.petersen@oracle.com> | 2019-08-12 21:34:06 -0400 |
| commit | 3a392b4f384a08919c93e5f751e9fffa1ad723e3 (patch) | |
| tree | 738f88a655c43897c422f4eea8fc07cdb6676bc8 /drivers/scsi/qla2xxx | |
| parent | scsi: qla2xxx: Fix qla24xx_process_bidir_cmd() (diff) | |
| download | linux-dev-3a392b4f384a08919c93e5f751e9fffa1ad723e3.tar.xz linux-dev-3a392b4f384a08919c93e5f751e9fffa1ad723e3.zip | |
scsi: qla2xxx: Remove unreachable code from qla83xx_idc_lock()
This was detected by Coverity.
Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Tested-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/qla2xxx')
| -rw-r--r-- | drivers/scsi/qla2xxx/qla_os.c | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 37e24987c852..2ba06a84c501 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -5720,7 +5720,6 @@ exit: void qla83xx_idc_lock(scsi_qla_host_t *base_vha, uint16_t requester_id) { - uint16_t options = (requester_id << 15) | BIT_6; uint32_t data; uint32_t lock_owner; struct qla_hw_data *ha = base_vha->hw; @@ -5753,22 +5752,6 @@ retry_lock: } return; - - /* XXX: IDC-lock implementation using access-control mbx */ -retry_lock2: - if (qla83xx_access_control(base_vha, options, 0, 0, NULL)) { - ql_dbg(ql_dbg_p3p, base_vha, 0xb072, - "Failed to acquire IDC lock. retrying...\n"); - /* Retry/Perform IDC-Lock recovery */ - if (qla83xx_idc_lock_recovery(base_vha) == QLA_SUCCESS) { - qla83xx_wait_logic(); - goto retry_lock2; - } else - ql_log(ql_log_warn, base_vha, 0xb076, - "IDC Lock recovery FAILED.\n"); - } - - return; } void |