aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi/qla4xxx
diff options
context:
space:
mode:
authoradam radford <aradford@gmail.com>2012-01-10 18:07:56 -0800
committerJames Bottomley <JBottomley@Parallels.com>2012-01-16 12:28:03 +0400
commit124dd90f6525ee785b47b59aebadd4a35f797dc1 (patch)
treede46f5d335a05c198567ae3d7b2a9a212fd04006 /drivers/scsi/qla4xxx
parent[SCSI] sg: convert to kstrtoul_from_user() (diff)
downloadlinux-dev-124dd90f6525ee785b47b59aebadd4a35f797dc1.tar.xz
linux-dev-124dd90f6525ee785b47b59aebadd4a35f797dc1.zip
[SCSI] megaraid: fix sparse warnings
There's a zero day mistake in the megaraid driver in that the code that obtains the version number does a >> 8 on a char quantity. This >>8 causes a sparse warning because it always produces zero. Al Viro suggested these shifts should be >> 4 thus treating the firmware version as a BCD quantity. However, in the interests of safety we've elected to replace the >> 8 quantities with an explicit zero, thus quieting the sparse warning while preserving the same (albeit incorrect) version number as had previously been seen. Signed-off-by: Adam Radford <aradford@gmail.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/qla4xxx')
0 files changed, 0 insertions, 0 deletions