diff options
| author |   Tejun Heo <htejun@gmail.com> | 2006-02-12 23:32:58 +0900 |
|---|---|---|
| committer |   Jeff Garzik <jgarzik@pobox.com> | 2006-02-12 14:29:10 -0500 |
| commit | 6e7846e9c548443c86cfbad9e4defb4bdcfc538b (patch) | |
| tree | f92fe0c3ca0000ad7d68bb3caae10d2066a7f78e /drivers/scsi/sata_sil24.c | |
| parent | [PATCH] libata: make ata_dev_knobble() per-device (diff) | |
| download | linux-dev-6e7846e9c548443c86cfbad9e4defb4bdcfc538b.tar.xz linux-dev-6e7846e9c548443c86cfbad9e4defb4bdcfc538b.zip | |
[PATCH] libata: move cdb_len for host to device
cdb_len is per-device property. Sharing cdb_len on ap results in
inaccurate configuration on revalidation and hotplugging. This patch
makes cdb_len per-device.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/scsi/sata_sil24.c')
| -rw-r--r-- | drivers/scsi/sata_sil24.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/sata_sil24.c b/drivers/scsi/sata_sil24.c index 228a7fabffff..24020c68903a 100644 --- a/drivers/scsi/sata_sil24.c +++ b/drivers/scsi/sata_sil24.c @@ -371,7 +371,7 @@ static void sil24_dev_config(struct ata_port *ap, struct ata_device *dev) { void __iomem *port = (void __iomem *)ap->ioaddr.cmd_addr; - if (ap->cdb_len == 16) + if (dev->cdb_len == 16) writel(PORT_CS_CDB16, port + PORT_CTRL_STAT); else writel(PORT_CS_CDB16, port + PORT_CTRL_CLR); @@ -543,7 +543,7 @@ static void sil24_qc_prep(struct ata_queued_cmd *qc) prb = &cb->atapi.prb; sge = cb->atapi.sge; memset(cb->atapi.cdb, 0, 32); - memcpy(cb->atapi.cdb, qc->cdb, ap->cdb_len); + memcpy(cb->atapi.cdb, qc->cdb, qc->dev->cdb_len); if (qc->tf.protocol != ATA_PROT_ATAPI_NODATA) { if (qc->tf.flags & ATA_TFLAG_WRITE) |