diff options
| author |   Alan Stern <stern@rowland.harvard.edu> | 2010-02-12 12:13:39 -0500 |
|---|---|---|
| committer |   James Bottomley <James.Bottomley@suse.de> | 2010-02-18 10:52:39 -0600 |
| commit | d5469119f0098881ab7f991990ef4f81ef13a194 (patch) | |
| tree | 62ffe8444a7692a222b59dc115c30b9047687e57 /drivers/scsi/scsi_scan.c | |
| parent | [SCSI] fix memory leak in scsi_report_lun_scan (diff) | |
| download | linux-dev-d5469119f0098881ab7f991990ef4f81ef13a194.tar.xz linux-dev-d5469119f0098881ab7f991990ef4f81ef13a194.zip | |
[SCSI] fix refcounting bug in scsi_get_host_dev
This patch (as1334) fixes a bug in scsi_get_host_dev(). It
incorrectly calls get_device() on the new device's target.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/scsi_scan.c')
| -rw-r--r-- | drivers/scsi/scsi_scan.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 60b262d66b5b..f697229ae5a9 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -1909,10 +1909,9 @@ struct scsi_device *scsi_get_host_dev(struct Scsi_Host *shost) goto out; sdev = scsi_alloc_sdev(starget, 0, NULL); - if (sdev) { - sdev->sdev_gendev.parent = get_device(&starget->dev); + if (sdev) sdev->borken = 0; - } else + else scsi_target_reap(starget); put_device(&starget->dev); out: |