diff options
| author |   Bart Van Assche <bart.vanassche@wdc.com> | 2017-08-25 13:46:33 -0700 |
|---|---|---|
| committer |   Martin K. Petersen <martin.petersen@oracle.com> | 2017-08-25 17:08:08 -0400 |
| commit | 0624cbb1e2e64ae4d7d55dc81fc39a0af87a2bd7 (patch) | |
| tree | e070944a3dd8aeb9583276371d5fa412a3b4e721 /drivers/scsi/sd.c | |
| parent | scsi: Use blk_mq_rq_to_pdu() to convert a request to a SCSI command pointer (diff) | |
| download | linux-dev-0624cbb1e2e64ae4d7d55dc81fc39a0af87a2bd7.tar.xz linux-dev-0624cbb1e2e64ae4d7d55dc81fc39a0af87a2bd7.zip | |
scsi: sd: sr: Convert two assignments into warning statements
Before scsi_prep_fn() calls the ULP .init_command() callback
function it stores the SCSI command pointer in request.special.
This means that the SCpnt = rq->special assignments in the sd
and sr drivers assign a pointer to itself. Hence convert these
two assignment statements into warning statements.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/sd.c')
| -rw-r--r-- | drivers/scsi/sd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index bea36adeee17..a88639fbedb3 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -1013,7 +1013,7 @@ static int sd_setup_read_write_cmnd(struct scsi_cmnd *SCpnt) ret = scsi_init_io(SCpnt); if (ret != BLKPREP_OK) goto out; - SCpnt = rq->special; + WARN_ON_ONCE(SCpnt != rq->special); /* from here on until we're complete, any goto out * is used for a killable error condition */ |