diff options
| author |   Martin K. Petersen <martin.petersen@oracle.com> | 2010-01-18 18:43:18 -0500 |
|---|---|---|
| committer |   James Bottomley <James.Bottomley@suse.de> | 2010-02-08 18:30:39 -0600 |
| commit | fa4698fcf59c3bd01c171e5e558bae9e8eb396f1 (patch) | |
| tree | 7c50e3c7d94ed1c855de23bf39b66f51e018661b /drivers/scsi/sd.c | |
| parent | [SCSI] lpfc: unify two if branches with the same code in lpfc_decode_firmware_rev() (diff) | |
| download | linux-dev-fa4698fcf59c3bd01c171e5e558bae9e8eb396f1.tar.xz linux-dev-fa4698fcf59c3bd01c171e5e558bae9e8eb396f1.zip | |
[SCSI] sd: Combine DIF/DIX error handling
DIF and DIX errors are handled identically at this point. Collapse the
switch cases into one and let scsi_io_completion print result and sense
data.
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/sd.c')
| -rw-r--r-- | drivers/scsi/sd.c | 15 |
1 files changed, 3 insertions, 12 deletions
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index c5e9a99d4066..908d400b601a 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -1196,19 +1196,10 @@ static int sd_done(struct scsi_cmnd *SCpnt) SCpnt->result = 0; memset(SCpnt->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE); break; - case ABORTED_COMMAND: - if (sshdr.asc == 0x10) { /* DIF: Disk detected corruption */ - scsi_print_result(SCpnt); - scsi_print_sense("sd", SCpnt); + case ABORTED_COMMAND: /* DIF: Target detected corruption */ + case ILLEGAL_REQUEST: /* DIX: Host detected corruption */ + if (sshdr.asc == 0x10) good_bytes = sd_completed_bytes(SCpnt); - } - break; - case ILLEGAL_REQUEST: - if (sshdr.asc == 0x10) { /* DIX: HBA detected corruption */ - scsi_print_result(SCpnt); - scsi_print_sense("sd", SCpnt); - good_bytes = sd_completed_bytes(SCpnt); - } break; default: break; |