diff options
| author |   Christoph Hellwig <hch@lst.de> | 2019-12-03 10:39:08 +0100 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2019-12-03 10:18:22 -0700 |
| commit | 6c6b3549142255c3fe4bab5560efdf8391c8d858 (patch) | |
| tree | 0a738d6947054942fedcd44f532d6579976c1c28 /drivers/scsi | |
| parent | block: don't handle bio based drivers in blk_revalidate_disk_zones (diff) | |
| download | linux-dev-6c6b3549142255c3fe4bab5560efdf8391c8d858.tar.xz linux-dev-6c6b3549142255c3fe4bab5560efdf8391c8d858.zip | |
block: set the zone size in blk_revalidate_disk_zones atomically
The current zone revalidation code has a major problem in that it
doesn't update the zone size and q->nr_zones atomically, leading
to a short window where an out of bounds access to the zone arrays
is possible.
To fix this move the setting of the zone size into the crticial
sections blk_revalidate_disk_zones so that it gets updated together
with the zone bitmaps and q->nr_zones. This also slightly simplifies
the caller as it deducts the zone size from the report_zones.
This change also allows to check for a power of two zone size in generic
code.
Reported-by: Hans Holmberg <hans@owltronix.com>
Reviewed-by: Javier González <javier@javigon.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/sd_zbc.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/scsi/sd_zbc.c b/drivers/scsi/sd_zbc.c index 0e5ede48f045..27d72c1d4654 100644 --- a/drivers/scsi/sd_zbc.c +++ b/drivers/scsi/sd_zbc.c @@ -412,8 +412,6 @@ int sd_zbc_read_zones(struct scsi_disk *sdkp, unsigned char *buf) goto err; /* The drive satisfies the kernel restrictions: set it up */ - blk_queue_chunk_sectors(sdkp->disk->queue, - logical_to_sectors(sdkp->device, zone_blocks)); blk_queue_flag_set(QUEUE_FLAG_ZONE_RESETALL, sdkp->disk->queue); blk_queue_required_elevator_features(sdkp->disk->queue, ELEVATOR_F_ZBD_SEQ_WRITE); |