diff options
| author |   Chen, Kenneth W <kenneth.w.chen@intel.com> | 2005-07-12 15:57:13 -0700 |
|---|---|---|
| committer |   James Bottomley <jejb@mulgrave.(none)> | 2005-07-14 11:25:17 -0400 |
| commit | 7fce2cf62e4bd9c24717009865ac00940cb664b8 (patch) | |
| tree | 4868666a6031372d9ad2301b170fef35540dc0ae /drivers/scsi | |
| parent | [SCSI] Redundant memset in scsi_alloc_sgtable (diff) | |
| download | linux-dev-7fce2cf62e4bd9c24717009865ac00940cb664b8.tar.xz linux-dev-7fce2cf62e4bd9c24717009865ac00940cb664b8.zip | |
[SCSI] Redundant this_count check in sd_init_command()
I was going over the scsi I/O submit path, when sd_init_command
construct the scsi command, this_count is already checked in the
previous else if clause. Why does it need to check it again in
the last else block?
Patch to delete the spurious check.
Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/sd.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index bb8235598787..0410e1bf109a 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -373,9 +373,6 @@ static int sd_init_command(struct scsi_cmnd * SCpnt) SCpnt->cmnd[7] = (unsigned char) (this_count >> 8) & 0xff; SCpnt->cmnd[8] = (unsigned char) this_count & 0xff; } else { - if (this_count > 0xff) - this_count = 0xff; - SCpnt->cmnd[1] |= (unsigned char) ((block >> 16) & 0x1f); SCpnt->cmnd[2] = (unsigned char) ((block >> 8) & 0xff); SCpnt->cmnd[3] = (unsigned char) block & 0xff; |