diff options
| author |   Chad Dupuis <chad.dupuis@qlogic.com> | 2015-08-04 13:38:00 -0400 |
|---|---|---|
| committer |   James Bottomley <JBottomley@Odin.com> | 2015-08-26 17:47:45 -0700 |
| commit | 96219424f2c7b767e42ccf203df40d7df677a5e3 (patch) | |
| tree | df3006bb36e4d2530fcbe27216a06abdc9eb097a /drivers/scsi | |
| parent | qla2xxx: Add support to show MPI and PEP FW version for ISP27xx. (diff) | |
| download | linux-dev-96219424f2c7b767e42ccf203df40d7df677a5e3.tar.xz linux-dev-96219424f2c7b767e42ccf203df40d7df677a5e3.zip | |
qla2xxx: Remove decrement of sp reference count in abort handler.
Fix for memory leak when command is not found by firmware due to
mismatch in sp reference count.
Signed-off-by: Chad Dupuis <chad.dupuis@qlogic.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/qla2xxx/qla_os.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index f70809feca90..95bee6807f46 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -967,14 +967,9 @@ qla2xxx_eh_abort(struct scsi_cmnd *cmd) spin_unlock_irqrestore(&ha->hardware_lock, flags); rval = ha->isp_ops->abort_command(sp); if (rval) { - if (rval == QLA_FUNCTION_PARAMETER_ERROR) { - /* - * Decrement the ref_count since we can't find the - * command - */ - atomic_dec(&sp->ref_count); + if (rval == QLA_FUNCTION_PARAMETER_ERROR) ret = SUCCESS; - } else + else ret = FAILED; ql_dbg(ql_dbg_taskm, vha, 0x8003, |