diff options
| author |   Leon Romanovsky <leonro@nvidia.com> | 2021-09-23 21:12:53 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-09-24 14:12:57 +0100 |
| commit | e6a54d6f221301347aaf9d83bb1f23129325c1c5 (patch) | |
| tree | 2b601cd16dd7e9901414d3e7faaf83e4a0208e81 /drivers/scsi | |
| parent | ice: Delete always true check of PF pointer (diff) | |
| download | linux-dev-e6a54d6f221301347aaf9d83bb1f23129325c1c5.tar.xz linux-dev-e6a54d6f221301347aaf9d83bb1f23129325c1c5.zip | |
qed: Don't ignore devlink allocation failures
devlink is a software interface that doesn't depend on any hardware
capabilities. The failure in SW means memory issues, wrong parameters,
programmer error e.t.c.
Like any other such interface in the kernel, the returned status of
devlink APIs should be checked and propagated further and not ignored.
Fixes: 755f982bb1ff ("qed/qede: make devlink survive recovery")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/qedf/qedf_main.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 42d0d941dba5..94ee08fab46a 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -3416,7 +3416,9 @@ retry_probe: qedf->devlink = qed_ops->common->devlink_register(qedf->cdev); if (IS_ERR(qedf->devlink)) { QEDF_ERR(&qedf->dbg_ctx, "Cannot register devlink\n"); + rc = PTR_ERR(qedf->devlink); qedf->devlink = NULL; + goto err2; } } |