diff options
| author |   Dolev Raviv <draviv@codeaurora.org> | 2014-10-23 13:25:16 +0300 |
|---|---|---|
| committer |   Christoph Hellwig <hch@lst.de> | 2014-11-20 17:47:41 +0100 |
| commit | eda910e4d03af878482055ce511a522d9bbda0e8 (patch) | |
| tree | 4d9d38f116c7e79869d6dc34cf5abea0533e52b7 /drivers/scsi | |
| parent | scsi: ufs: fix static checker warning in ufshcd_populate_vreg (diff) | |
| download | linux-dev-eda910e4d03af878482055ce511a522d9bbda0e8.tar.xz linux-dev-eda910e4d03af878482055ce511a522d9bbda0e8.zip | |
scsi: ufs: fix static checker warning in __ufshcd_setup_clocks
This patch fixes newly introduced static checker warning in
__ufshcd_setup_clocks, introduced by UFS power management series.
Warning:
drivers/scsi/ufs/ufshcd.c:4474 __ufshcd_setup_clocks()
warn: we tested 'ret' before and it was 'false'
To fix it we remove the (!ret) from the condition.
Signed-off-by: Dolev Raviv <draviv@codeaurora.org>
Reviewed-by: Maya Erez <merez@codeaurora.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/ufs/ufshcd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index d3f6ddb5d99b..b9da4463cefb 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -4473,7 +4473,7 @@ out: if (!IS_ERR_OR_NULL(clki->clk) && clki->enabled) clk_disable_unprepare(clki->clk); } - } else if (!ret && on) { + } else if (on) { spin_lock_irqsave(hba->host->host_lock, flags); hba->clk_gating.state = CLKS_ON; spin_unlock_irqrestore(hba->host->host_lock, flags); |