aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorJames Smart <james.smart@broadcom.com>2021-06-19 08:56:41 -0700
committerMartin K. Petersen <martin.petersen@oracle.com>2021-06-22 21:07:30 -0400
commitf6060eb1344717bf22d592a6e1b69818b07cad6e (patch)
tree3acd2fd818b7d749519784b38aef80468f218bad /drivers/scsi
parentscsi: aha1740: Avoid over-read of sense buffer (diff)
downloadlinux-dev-f6060eb1344717bf22d592a6e1b69818b07cad6e.tar.xz
linux-dev-f6060eb1344717bf22d592a6e1b69818b07cad6e.zip
scsi: elx: libefc_sli: Fix ANDing with zero bit value
Flags value is being set to a constant and ANDed with 0 which always results in 0. Remove the assignment line. Link: https://lore.kernel.org/r/20210619155641.19942-1-jsmart2021@gmail.com Fixes: 1628f5b4976f ("scsi: elx: libefc_sli: Populate and post different WQEs") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Co-developed-by: Ram Vegesna <ram.vegesna@broadcom.com> Signed-off-by: Ram Vegesna <ram.vegesna@broadcom.com> Signed-off-by: James Smart <james.smart@broadcom.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/elx/libefc_sli/sli4.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/scsi/elx/libefc_sli/sli4.c b/drivers/scsi/elx/libefc_sli/sli4.c
index fc24a50c5d6b..6c6c04e1b74d 100644
--- a/drivers/scsi/elx/libefc_sli/sli4.c
+++ b/drivers/scsi/elx/libefc_sli/sli4.c
@@ -2381,8 +2381,6 @@ sli_xmit_els_rsp64_wqe(struct sli4 *sli, void *buf, struct efc_dma *rsp,
els->ox_id = cpu_to_le16(params->ox_id);
- els->flags2 |= SLI4_ELS_IOD & SLI4_ELS_REQUEST64_DIR_WRITE;
-
els->flags2 |= SLI4_ELS_QOSD;
els->cmd_type_wqec = SLI4_ELS_REQUEST64_CMD_GEN;