diff options
| author |   Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> | 2013-05-21 23:24:22 +0400 |
|---|---|---|
| committer |   Tejun Heo <tj@kernel.org> | 2013-06-02 01:14:40 -0700 |
| commit | f6e984e63638e3bfb0f13f603a0e972a6da07deb (patch) | |
| tree | bda2b6bc9bf89ac0b7af8710924c614a7c8d5d32 /drivers/scsi | |
| parent | sata_rcar: add 'base' local variable to some functions (diff) | |
| download | linux-dev-f6e984e63638e3bfb0f13f603a0e972a6da07deb.tar.xz linux-dev-f6e984e63638e3bfb0f13f603a0e972a6da07deb.zip | |
ipr: qc_fill_rtf() method should not store alternate status register
The 'ctl' field of the 'struct ata_taskfile' is not really dual purpose, i.e.
it is not intended for storing the alternate status register (which is mapped
at the same address in the legacy IDE controllers) in the qc_fill_rtf() method.
No other 'libata' driver except 'drivers/scsi/ipr.c' stores the alternate status
register's value in the 'ctl' field of 'qc->result_tf', hence this driver should
not do this as well...
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/ipr.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c index 82a3c1ec8706..e6b05ec4194b 100644 --- a/drivers/scsi/ipr.c +++ b/drivers/scsi/ipr.c @@ -6662,7 +6662,6 @@ static bool ipr_qc_fill_rtf(struct ata_queued_cmd *qc) tf->hob_lbal = g->hob_lbal; tf->hob_lbam = g->hob_lbam; tf->hob_lbah = g->hob_lbah; - tf->ctl = g->alt_status; return true; } |