diff options
| author |   Srinivas Kandagatla <srinivas.kandagatla@linaro.org> | 2019-08-18 10:39:02 +0100 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-08-18 12:56:10 +0200 |
| commit | fcaf3d933926e36a264939e6d3d3cb62b42695b8 (patch) | |
| tree | 459a4f24ab567d42b70817b9ada042518c46bc5e /drivers/slimbus | |
| parent | slimbus: qcom-ngd-ctrl: Add of_node_put() before return (diff) | |
| download | linux-dev-fcaf3d933926e36a264939e6d3d3cb62b42695b8.tar.xz linux-dev-fcaf3d933926e36a264939e6d3d3cb62b42695b8.zip | |
slimbus: fix slim_tid_txn()
fix below issue reported by coccicheck
./drivers/slimbus/slimbus.h:440:3-46: duplicated argument to && or ||
Looks like this was a typo, SLIM_MSG_MC_REQUEST_CHANGE_VALUE is command
which requires transaction ID, so fix it, this also fix the warning.
Reported-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20190818093902.29993-3-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/slimbus')
| -rw-r--r-- | drivers/slimbus/slimbus.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/slimbus/slimbus.h b/drivers/slimbus/slimbus.h index 9be41089edde..b2f013bfe42e 100644 --- a/drivers/slimbus/slimbus.h +++ b/drivers/slimbus/slimbus.h @@ -439,7 +439,7 @@ static inline bool slim_tid_txn(u8 mt, u8 mc) (mc == SLIM_MSG_MC_REQUEST_INFORMATION || mc == SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION || mc == SLIM_MSG_MC_REQUEST_VALUE || - mc == SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION)); + mc == SLIM_MSG_MC_REQUEST_CHANGE_VALUE)); } static inline bool slim_ec_txn(u8 mt, u8 mc) |