diff options
| author |   Florian Fainelli <f.fainelli@gmail.com> | 2022-09-15 12:01:59 -0700 |
|---|---|---|
| committer | Florian Fainelli <f.fainelli@gmail.com> | 2022-09-15 14:30:29 -0700 |
| commit | 90d000288e115ca63452813c423f9dfd9f521c96 (patch) | |
| tree | d121348ce0f21d633aa8715f8298ab8390bff283 /drivers/soc/bcm | |
| parent | soc: brcmstb: pm-arm: Fix refcount leak and __iomem leak bugs (diff) | |
| download | linux-dev-90d000288e115ca63452813c423f9dfd9f521c96.tar.xz linux-dev-90d000288e115ca63452813c423f9dfd9f521c96.zip | |
soc: bcm: brcmstb: biuctrl: Avoid double of_node_put()
Commit 9a073d4fbb18 ("soc: bcm: brcmstb: biuctrl: Add missing
of_node_put()") added what was thought to be a missing of_node_put() but
now causes a double of_node_put() to be called, once from
setup_hifcpubiuctrl_regs() and another time from brcmstb_biuctrl_init().
Ensure that setup_hifcpubiuctrl_regs() is not calling of_node_put()
since it is not obvious it does that on one of its parameters.
Fixes: 9a073d4fbb18 ("soc: bcm: brcmstb: biuctrl: Add missing of_node_put()")
Reported-by: Jim Quinlan <jim2101024@gmail.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Change-Id: I1c405c36c2f06c8b8c0f684143b7a52db7e809f0
Diffstat (limited to 'drivers/soc/bcm')
| -rw-r--r-- | drivers/soc/bcm/brcmstb/biuctrl.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/soc/bcm/brcmstb/biuctrl.c b/drivers/soc/bcm/brcmstb/biuctrl.c index 1467bbd59690..e1d7b4543248 100644 --- a/drivers/soc/bcm/brcmstb/biuctrl.c +++ b/drivers/soc/bcm/brcmstb/biuctrl.c @@ -288,7 +288,6 @@ static int __init setup_hifcpubiuctrl_regs(struct device_node *np) if (BRCM_ID(family_id) == 0x7260 && BRCM_REV(family_id) == 0) cpubiuctrl_regs = b53_cpubiuctrl_no_wb_regs; out: - of_node_put(np); return ret; } |