diff options
| author |   Jiasheng Jiang <jiasheng@iscas.ac.cn> | 2021-12-31 17:44:19 +0800 |
|---|---|---|
| committer |   Bjorn Andersson <bjorn.andersson@linaro.org> | 2022-01-31 15:57:00 -0600 |
| commit | 5a811126d38f9767a20cc271b34db7c8efc5a46c (patch) | |
| tree | 9e5a00293f67b3cdf86f422e942ead048ec9043c /drivers/soc/qcom/rpmpd.c | |
| parent | firmware: qcom: scm: Fix some kernel-doc comments (diff) | |
| download | linux-dev-5a811126d38f9767a20cc271b34db7c8efc5a46c.tar.xz linux-dev-5a811126d38f9767a20cc271b34db7c8efc5a46c.zip | |
soc: qcom: rpmpd: Check for null return of devm_kcalloc
Because of the possible failure of the allocation, data->domains might
be NULL pointer and will cause the dereference of the NULL pointer
later.
Therefore, it might be better to check it and directly return -ENOMEM
without releasing data manually if fails, because the comment of the
devm_kmalloc() says "Memory allocated with this function is
automatically freed on driver detach.".
Fixes: bbe3a66c3f5a ("soc: qcom: rpmpd: Add a Power domain driver to model corners")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20211231094419.1941054-1-jiasheng@iscas.ac.cn
Diffstat (limited to 'drivers/soc/qcom/rpmpd.c')
| -rw-r--r-- | drivers/soc/qcom/rpmpd.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c index 0a8d8d24bfb7..624b5630feb8 100644 --- a/drivers/soc/qcom/rpmpd.c +++ b/drivers/soc/qcom/rpmpd.c @@ -610,6 +610,9 @@ static int rpmpd_probe(struct platform_device *pdev) data->domains = devm_kcalloc(&pdev->dev, num, sizeof(*data->domains), GFP_KERNEL); + if (!data->domains) + return -ENOMEM; + data->num_domains = num; for (i = 0; i < num; i++) { |