diff options
| author |   Axel Lin <axel.lin@ingics.com> | 2014-11-03 10:21:54 -0800 |
|---|---|---|
| committer |   Santosh Shilimkar <santosh.shilimkar@oracle.com> | 2014-11-03 10:22:06 -0800 |
| commit | 148bb0439adeeae466dca31dd4c643e194bee023 (patch) | |
| tree | e8bfa8d36d8493c96c7409248f3d2b68fd5c097e /drivers/soc/ti | |
| parent | soc: ti: knav_qmss_queue: Return proper error if devm_kzalloc fails (diff) | |
| download | linux-dev-148bb0439adeeae466dca31dd4c643e194bee023.tar.xz linux-dev-148bb0439adeeae466dca31dd4c643e194bee023.zip | |
soc: ti: knav_qmss_queue: Use list_for_each_entry_safe to prevent use after free
list_for_each_entry_safe() is necessary if list objects are deleted from
the list while traversing it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Santosh Shilimkar <ssantosh@kernel.org>
Diffstat (limited to 'drivers/soc/ti')
| -rw-r--r-- | drivers/soc/ti/knav_qmss_queue.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c index 6f22d5622c98..9b8dd6732681 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -1306,14 +1306,14 @@ static void knav_free_queue_ranges(struct knav_device *kdev) static void knav_queue_free_regions(struct knav_device *kdev) { struct knav_region *region; - struct knav_pool *pool; + struct knav_pool *pool, *tmp; unsigned size; for (;;) { region = first_region(kdev); if (!region) break; - list_for_each_entry(pool, ®ion->pools, region_inst) + list_for_each_entry_safe(pool, tmp, ®ion->pools, region_inst) knav_pool_destroy(pool); size = region->virt_end - region->virt_start; |