diff options
| author |   Yu Kuai <yukuai3@huawei.com> | 2020-11-17 09:13:22 +0800 |
|---|---|---|
| committer |   Kevin Hilman <khilman@baylibre.com> | 2020-11-30 16:22:48 -0800 |
| commit | 28f851e6afa858f182802e23ac60c3ed7d1c04a1 (patch) | |
| tree | 6a1dad51678e4cc39c4827ac6ad03a910d0284cd /drivers/soc | |
| parent | firmware: meson-sm: enable build as module (diff) | |
| download | linux-dev-28f851e6afa858f182802e23ac60c3ed7d1c04a1.tar.xz linux-dev-28f851e6afa858f182802e23ac60c3ed7d1c04a1.zip | |
soc: amlogic: canvas: add missing put_device() call in meson_canvas_get()
if of_find_device_by_node() succeed, meson_canvas_get() doesn't have
a corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.
Fixes: 382f8be04551 ("soc: amlogic: canvas: Fix meson_canvas_get when probe failed")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
Link: https://lore.kernel.org/r/20201117011322.522477-1-yukuai3@huawei.com
Diffstat (limited to 'drivers/soc')
| -rw-r--r-- | drivers/soc/amlogic/meson-canvas.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/soc/amlogic/meson-canvas.c b/drivers/soc/amlogic/meson-canvas.c index c655f5f92b12..d0329ad170d1 100644 --- a/drivers/soc/amlogic/meson-canvas.c +++ b/drivers/soc/amlogic/meson-canvas.c @@ -72,8 +72,10 @@ struct meson_canvas *meson_canvas_get(struct device *dev) * current state, this driver probe cannot return -EPROBE_DEFER */ canvas = dev_get_drvdata(&canvas_pdev->dev); - if (!canvas) + if (!canvas) { + put_device(&canvas_pdev->dev); return ERR_PTR(-EINVAL); + } return canvas; } |