diff options
| author |   Alexey Khoroshilov <khoroshilov@ispras.ru> | 2018-12-08 01:57:04 +0300 |
|---|---|---|
| committer |   Andy Gross <andy.gross@linaro.org> | 2019-02-01 16:08:52 -0600 |
| commit | 8cd09a3dd3e176c62da67efcd477a44a8d87185e (patch) | |
| tree | 48e8731922d3bbcd09c836cc52c1588d65494e92 /drivers/soc | |
| parent | soc: qcom: rpmh: Avoid accessing freed memory from batch API (diff) | |
| download | linux-dev-8cd09a3dd3e176c62da67efcd477a44a8d87185e.tar.xz linux-dev-8cd09a3dd3e176c62da67efcd477a44a8d87185e.zip | |
soc: qcom: gsbi: Fix error handling in gsbi_probe()
If of_platform_populate() fails in gsbi_probe(),
gsbi->hclk is left undisabled.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>
Diffstat (limited to 'drivers/soc')
| -rw-r--r-- | drivers/soc/qcom/qcom_gsbi.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c index 09c669e70d63..038abc377fdb 100644 --- a/drivers/soc/qcom/qcom_gsbi.c +++ b/drivers/soc/qcom/qcom_gsbi.c @@ -138,7 +138,7 @@ static int gsbi_probe(struct platform_device *pdev) struct resource *res; void __iomem *base; struct gsbi_info *gsbi; - int i; + int i, ret; u32 mask, gsbi_num; const struct crci_config *config = NULL; @@ -221,7 +221,10 @@ static int gsbi_probe(struct platform_device *pdev) platform_set_drvdata(pdev, gsbi); - return of_platform_populate(node, NULL, NULL, &pdev->dev); + ret = of_platform_populate(node, NULL, NULL, &pdev->dev); + if (ret) + clk_disable_unprepare(gsbi->hclk); + return ret; } static int gsbi_remove(struct platform_device *pdev) |