diff options
| author |   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> | 2022-09-20 01:57:11 +0800 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2022-09-20 10:39:22 +0530 |
| commit | c6867cda906aadbce5e71efde9c78a26108b2bad (patch) | |
| tree | 36e6c0758707c1023fab0bedbde2517b216ddd95 /drivers/soundwire/intel.c | |
| parent | soundwire: cadence: Simplify error paths in cdns_xfer_msg() (diff) | |
| download | linux-dev-c6867cda906aadbce5e71efde9c78a26108b2bad.tar.xz linux-dev-c6867cda906aadbce5e71efde9c78a26108b2bad.zip | |
soundwire: intel: fix error handling on dai registration issues
The call to intel_register_dai() may fail because of memory allocation
issues or problems reported by the ASoC core. In all cases, when a
error is thrown the component is not registered, it's invalid to
unregister it.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20220919175721.354679-2-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/soundwire/intel.c')
| -rw-r--r-- | drivers/soundwire/intel.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index 01be62fa6c83..3bb29bc00d5a 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -1432,7 +1432,6 @@ int intel_link_startup(struct auxiliary_device *auxdev) ret = intel_register_dai(sdw); if (ret) { dev_err(dev, "DAI registration failed: %d\n", ret); - snd_soc_unregister_component(dev); goto err_interrupt; } |